New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename Shortcode everywhere and use its type in KnoraProject property (NO-TICKET) #2724
refactor: Rename Shortcode everywhere and use its type in KnoraProject property (NO-TICKET) #2724
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2724 +/- ##
===========================================
+ Coverage 18.00% 82.39% +64.39%
===========================================
Files 281 280 -1
Lines 28899 28899
===========================================
+ Hits 5202 23812 +18610
+ Misses 23697 5087 -18610
☔ View full report in Codecov by Sentry. |
e14fba0
to
02bdb48
Compare
02bdb48
to
80623b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We at some point took the conscious decision that we wanted to change shortcode to camel case (I think there must be a notion page somewhere, where we recorded naming decisions), but we never really tackled it, and it's probably easier to just keep the old capitalization, so I'm absolutely fine with this.
I think the same applies for shortname too, which then probably should be changed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Good point and easy cheese: #2733 |
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?