New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Align path variable for export and import routes to use Shortcode #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2734 +/- ##
=========================================
- Coverage 18.00% 9.54% -8.46%
=========================================
Files 281 281
Lines 28899 28895 -4
=========================================
- Hits 5202 2759 -2443
- Misses 23697 26136 +2439
☔ View full report in Codecov by Sentry. |
seakayone
changed the title
Path export import api use shortcode
feat: Path export import api use shortcode
Jul 4, 2023
seakayone
changed the title
feat: Path export import api use shortcode
fix: Path export import api use shortcode
Jul 4, 2023
seakayone
changed the title
fix: Path export import api use shortcode
fix: Align path variable for export and import routes to use Shortcode
Jul 4, 2023
BalduinLandolt
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-2399
Align import and export endpoint to use
Shortcode
as identifier in both routes.Remove unused factory method
Shortcode.make(Option[String])
.Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?