Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align path variable for export and import routes to use Shortcode #2734

Merged
merged 6 commits into from Jul 4, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Jul 4, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-2399

Align import and export endpoint to use Shortcode as identifier in both routes.

Remove unused factory method Shortcode.make(Option[String]).

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 31.08% and project coverage change: -8.46 ⚠️

Comparison is base (12402f3) 18.00% compared to head (ad4eb7f) 9.54%.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #2734      +/-   ##
=========================================
- Coverage   18.00%   9.54%   -8.46%     
=========================================
  Files         281     281              
  Lines       28899   28895       -4     
=========================================
- Hits         5202    2759    -2443     
- Misses      23697   26136    +2439     
Impacted Files Coverage Δ
...sponder/projectsmessages/ProjectsPayloadsADM.scala 0.00% <0.00%> (ø)
...ora/webapi/responders/v1/ProjectsResponderV1.scala 0.00% <0.00%> (-4.52%) ⬇️
...rg/knora/webapi/routing/admin/ProjectsRouteZ.scala 94.11% <0.00%> (+2.68%) ⬆️
.../org/knora/webapi/routing/v1/ProjectsRouteV1.scala 0.00% <0.00%> (ø)
...org/knora/webapi/routing/v1/ResourcesRouteV1.scala 0.00% <0.00%> (ø)
...ice/admin/api/service/ProjectsADMRestService.scala 48.57% <0.00%> (-11.43%) ⬇️
...i/slice/admin/domain/service/DspIngestClient.scala 0.00% <0.00%> (-4.77%) ⬇️
.../slice/admin/domain/service/KnoraProjectRepo.scala 0.00% <0.00%> (ø)
...ce/admin/domain/service/ProjectExportService.scala 0.00% <0.00%> (-68.19%) ⬇️
...n/domain/service/ProjectExportStorageService.scala 17.39% <0.00%> (-5.34%) ⬇️
... and 7 more

... and 92 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone changed the title Path export import api use shortcode feat: Path export import api use shortcode Jul 4, 2023
@seakayone seakayone marked this pull request as ready for review July 4, 2023 09:00
@seakayone seakayone changed the title feat: Path export import api use shortcode fix: Path export import api use shortcode Jul 4, 2023
@seakayone seakayone changed the title fix: Path export import api use shortcode fix: Align path variable for export and import routes to use Shortcode Jul 4, 2023
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seakayone seakayone enabled auto-merge (squash) July 4, 2023 12:00
@seakayone seakayone merged commit 8cc2c62 into main Jul 4, 2023
12 checks passed
@seakayone seakayone deleted the path-export-import-api-use-shortcode branch July 4, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants