Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove file path from temporaryUrl in upload response of Sipi #2737

Merged
merged 2 commits into from Jul 6, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Jul 6, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-2320

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this Jul 6, 2023
@seakayone seakayone marked this pull request as ready for review July 6, 2023 06:29
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 63.29% and project coverage change: +64.39 🎉

Comparison is base (12402f3) 18.00% compared to head (2c2175f) 82.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2737       +/-   ##
===========================================
+ Coverage   18.00%   82.39%   +64.39%     
===========================================
  Files         281      281               
  Lines       28899    28891        -8     
===========================================
+ Hits         5202    23806    +18604     
+ Misses      23697     5085    -18612     
Impacted Files Coverage Δ
...main/scala/org/knora/webapi/config/AppConfig.scala 85.29% <ø> (-1.55%) ⬇️
...rg/knora/webapi/routing/admin/ProjectsRouteZ.scala 94.11% <0.00%> (+2.68%) ⬆️
.../org/knora/webapi/routing/v1/ProjectsRouteV1.scala 11.11% <0.00%> (+11.11%) ⬆️
...org/knora/webapi/routing/v1/ResourcesRouteV1.scala 2.00% <0.00%> (+2.00%) ⬆️
...ice/admin/api/service/ProjectsADMRestService.scala 60.00% <0.00%> (ø)
...i/slice/admin/domain/service/DspIngestClient.scala 4.76% <0.00%> (ø)
.../slice/admin/domain/service/KnoraProjectRepo.scala 0.00% <0.00%> (ø)
...ce/admin/domain/service/ProjectExportService.scala 68.18% <0.00%> (ø)
...ce/admin/domain/service/ProjectImportService.scala 44.89% <0.00%> (+32.65%) ⬆️
...ebapi/store/cache/impl/CacheServiceInMemImpl.scala 100.00% <ø> (+21.27%) ⬆️
... and 11 more

... and 182 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seakayone seakayone enabled auto-merge (squash) July 6, 2023 09:29
@seakayone seakayone merged commit 00e3b39 into main Jul 6, 2023
12 of 13 checks passed
@seakayone seakayone deleted the fix/sipi-upload-response-temporary-url branch July 6, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants