Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify GroupStatus model #2741

Merged
merged 3 commits into from Jul 7, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Jul 7, 2023

Pull Request Checklist

Task Description/Number

Issue Number: NO-TICKET

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this Jul 7, 2023
@seakayone seakayone marked this pull request as ready for review July 7, 2023 06:25
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 23.00% and project coverage change: -8.47 ⚠️

Comparison is base (12402f3) 18.00% compared to head (019d496) 9.53%.

❗ Current head 019d496 differs from pull request most recent head 665dbcb. Consider uploading reports for the commit 665dbcb to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #2741      +/-   ##
=========================================
- Coverage   18.00%   9.53%   -8.47%     
=========================================
  Files         281     281              
  Lines       28899   28879      -20     
=========================================
- Hits         5202    2755    -2447     
- Misses      23697   26124    +2427     
Impacted Files Coverage Δ
...main/scala/org/knora/webapi/config/AppConfig.scala 85.29% <ø> (-1.55%) ⬇️
...c/main/scala/org/knora/webapi/core/AppRouter.scala 0.00% <ø> (-100.00%) ⬇️
...c/main/scala/org/knora/webapi/core/AppServer.scala 0.00% <0.00%> (-86.77%) ⬇️
...sponder/projectsmessages/ProjectsPayloadsADM.scala 0.00% <0.00%> (ø)
...tore/triplestoremessages/TriplestoreMessages.scala 18.18% <0.00%> (-35.61%) ⬇️
...esponder/ontologymessages/OntologyMessagesV2.scala 2.63% <ø> (-3.61%) ⬇️
...scala/org/knora/webapi/responders/IriService.scala 0.00% <0.00%> (-69.24%) ⬇️
...a/webapi/responders/admin/GroupsResponderADM.scala 0.00% <0.00%> (-16.49%) ⬇️
...api/responders/admin/PermissionsResponderADM.scala 0.00% <0.00%> (-30.87%) ⬇️
...a/webapi/responders/admin/StoresResponderADM.scala 0.00% <0.00%> (-33.34%) ⬇️
... and 26 more

... and 78 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You've just omitted tests in GroupsResponderADMSpec which failed. Please fix them before merge.

@seakayone seakayone enabled auto-merge (squash) July 7, 2023 07:32
@seakayone seakayone merged commit 0b6d102 into main Jul 7, 2023
11 checks passed
@seakayone seakayone deleted the refactor/implify-group-status-factory-methods branch July 7, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants