refactor: Speedup /projects endpoint #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2824 +/- ##
===========================================
+ Coverage 18.00% 87.85% +69.85%
===========================================
Files 281 242 -39
Lines 28899 23323 -5576
===========================================
+ Hits 5202 20490 +15288
+ Misses 23697 2833 -20864 ☔ View full report in Codecov by Sentry. |
mpro7
approved these changes
Sep 6, 2023
| @@ -29,6 +29,9 @@ final case class KnoraProjectRepoInMemory(projects: Ref[List[KnoraProject]]) | |||
| } | |||
| ) | |||
| ) | |||
|
|
|||
| override def findOntologies(project: KnoraProject): Task[List[InternalIri]] = | |||
| throw new UnsupportedOperationException("not implemented (yet)") | |||
There was a problem hiding this comment.
Suggested change
| throw new UnsupportedOperationException("not implemented (yet)") | |
| throw new UnsupportedOperationException("Not yet implemented.") |
| @@ -29,6 +29,9 @@ final case class KnoraProjectRepoInMemory(projects: Ref[List[KnoraProject]]) | |||
| case IriIdentifier(iri) => _.id.value == iri.value | |||
| }) | |||
| ) | |||
|
|
|||
| override def findOntologies(project: KnoraProject): Task[List[InternalIri]] = | |||
| throw new UnsupportedOperationException("not yet implemented") | |||
There was a problem hiding this comment.
Suggested change
| throw new UnsupportedOperationException("not yet implemented") | |
| throw new UnsupportedOperationException("Not yet implemented.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load Ontologies from db with single query and parallelise converting
KnoraProjecttoProjectADMPull Request Checklist
Task Description/Number
NO-TICKET
I found that loading the start page with the project overview takes very long.
This is partly due to the fact that the app is loading the projects list with
/projectwhich is a slow endpoint, which is also called twice during initial loading.This change speeding up the conversion of a
KnoraProjectto a richerProjectADMby parallelising the lookup of the ontology a project is attached to. Since the cache and an actual database lookup are pretty similar I have also removed the dependency on theOntologyCache.Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?