refactor: Remove unused or dead code

[seakayone]

Pull Request Checklist

Task Description/Number

Issue Number: NO-TICKET

Just some clean up in order to reduce compiler warnings

Basic Requirements

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• fix: represents bug fixes
• refactor: represents production code refactoring
• feat: represents a new feature
• docs: documentation changes (no production code change)
• chore: maintenance tasks (no production code change)
• test: all about tests: adding, refactoring tests (no production code change)
• other... Please describe:

Does this PR introduce a breaking change?

• Yes
• No
• Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

• Yes (don't forget to update the JS-LIB team about the change)
• No

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +67.40% 🎉

Comparison is base (12402f3) 18.00% compared to head (5304d31) 85.40%.
Report is 54 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2827       +/-   ##
===========================================
+ Coverage   18.00%   85.40%   +67.40%     
===========================================
  Files         281      242       -39     
  Lines       28899    23153     -5746     
===========================================
+ Hits         5202    19774    +14572     
+ Misses      23697     3379    -20318     

see 247 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mpro7]

Thanks for the cleanup. I just wonder if you have checked the edge cases of removed defaults, or at least if there are covered by tests?

[seakayone]

Thanks for the cleanup. I just wonder if you have checked the edge cases of removed defaults, or at least if there are covered by tests?

I have only removed default values for which I have had a compiler warning that they are unused.
Am I missing something else here?

[mpro7]

Thanks for the cleanup. I just wonder if you have checked the edge cases of removed defaults, or at least if there are covered by tests?

I have only removed default values for which I have had a compiler warning that they are unused. Am I missing something else here?

I don't think so, this means all good.