Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SystemAdmins receive a token which is valid on the dps-ingest api #2835

Merged
merged 5 commits into from Sep 14, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Sep 14, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +70.04% 🎉

Comparison is base (12402f3) 18.00% compared to head (3cd709f) 88.04%.
Report is 61 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2835       +/-   ##
===========================================
+ Coverage   18.00%   88.04%   +70.04%     
===========================================
  Files         281      243       -38     
  Lines       28899    23089     -5810     
===========================================
+ Hits         5202    20329    +15127     
+ Misses      23697     2760    -20937     

see 225 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone self-assigned this Sep 14, 2023
@seakayone seakayone marked this pull request as ready for review September 14, 2023 12:41
@seakayone seakayone merged commit 469f228 into main Sep 14, 2023
13 checks passed
@seakayone seakayone deleted the feat/allow-sysadmins-dsp-ingest-access branch September 14, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants