Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Introduce tapir on Pekko DEV-2806 #2870

Merged
merged 10 commits into from Oct 11, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Oct 5, 2023

Migrate all public ProjectEndpoints to Tapir

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone changed the title refactor: Introduce tapir on Akka refactor: Introduce tapir on Pekko Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (e721bc4) 88.10%.
Report is 83 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2870       +/-   ##
===========================================
+ Coverage   18.00%   88.10%   +70.10%     
===========================================
  Files         281      252       -29     
  Lines       28899    23257     -5642     
===========================================
+ Hits         5202    20491    +15289     
+ Misses      23697     2766    -20931     

see 237 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Migrate all public ProjectEndpoints to Tapir
@seakayone seakayone requested a review from mpro7 October 10, 2023 15:35
@seakayone seakayone self-assigned this Oct 10, 2023
@seakayone seakayone requested review from BalduinLandolt and mpro7 and removed request for mpro7 October 10, 2023 15:35
@seakayone seakayone marked this pull request as ready for review October 11, 2023 06:05
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait and see what the outcome of our discussion on the topic will be. But as it stands, looks good to me

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor improvement which can be omitted:

…tsResponderADM.scala

Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
@seakayone seakayone enabled auto-merge (squash) October 11, 2023 13:56
@seakayone seakayone merged commit 08accab into main Oct 11, 2023
13 checks passed
@seakayone seakayone deleted the chore/add-tapir-dependencies branch October 11, 2023 14:23
@seakayone seakayone changed the title refactor: Introduce tapir on Pekko refactor: Introduce tapir on Pekko DEV-2806 Oct 13, 2023
@linear
Copy link

linear bot commented Oct 13, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants