New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Introduce tapir on Pekko DEV-2806 #2870
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2870 +/- ##
===========================================
+ Coverage 18.00% 88.10% +70.10%
===========================================
Files 281 252 -29
Lines 28899 23257 -5642
===========================================
+ Hits 5202 20491 +15289
+ Misses 23697 2766 -20931 ☔ View full report in Codecov by Sentry. |
Migrate all public ProjectEndpoints to Tapir
456a684
to
26df5d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait and see what the outcome of our discussion on the topic will be. But as it stands, looks good to me
webapi/src/main/scala/org/knora/webapi/routing/HandlerMapperF.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor improvement which can be omitted:
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Outdated
Show resolved
Hide resolved
…tsResponderADM.scala Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
Migrate all public ProjectEndpoints to Tapir
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?