Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce /admin/maintenance and expose fix top left maintenance action DEV-2805 #2877

Merged
merged 42 commits into from Oct 12, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Oct 11, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this Oct 11, 2023
@seakayone seakayone changed the title Feat/expose topleft transpose maintenance feat: Introduce /admin/maintenance and expose fix top left maintenance action Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (e9e2b14) 88.12%.
Report is 86 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2877       +/-   ##
===========================================
+ Coverage   18.00%   88.12%   +70.12%     
===========================================
  Files         281      254       -27     
  Lines       28899    23281     -5618     
===========================================
+ Hits         5202    20517    +15315     
+ Misses      23697     2764    -20933     

see 241 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone changed the title feat: Introduce /admin/maintenance and expose fix top left maintenance action feat: Introduce /admin/maintenance and expose fix top left maintenance action DEV-2805 Oct 12, 2023
@linear
Copy link

linear bot commented Oct 12, 2023

@seakayone seakayone marked this pull request as ready for review October 12, 2023 10:39
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seakayone seakayone merged commit a6b8c2f into main Oct 12, 2023
14 checks passed
@seakayone seakayone deleted the feat/expose-topleft-transpose-maintenance branch October 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants