Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove invalid ProjectAdminOntologyAllPermission (DEV-2814) #2881

Conversation

jnussbaum
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@linear
Copy link

linear bot commented Oct 13, 2023

DEV-2814 remove invalid ProjectAdminOntologyAllPermission from docs

ProjectAdminOntologyAllPermission doesn't exist any more, but it is still mentioned in the docs. When I try to use it, I get this error:

dsp.errors.BadRequestException: 
Invalid value for name parameter of hasPermissions: ProjectAdminOntologyAllPermission, 
it should be one of List(ProjectResourceCreateAllPermission, ProjectResourceCreateRestrictedPermission, ProjectAdminAllPermission, ProjectAdminGroupAllPermission, ProjectAdminGroupRestrictedPermission, ProjectAdminRightsAllPermission)

@jnussbaum jnussbaum self-assigned this Oct 13, 2023
@jnussbaum jnussbaum changed the title fix(docs): remove invalid ProjectAdminOntologyAllPermission fix(docs): remove invalid ProjectAdminOntologyAllPermission (DEV-2814) Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (96ab275) 88.12%.
Report is 88 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2881       +/-   ##
===========================================
+ Coverage   18.00%   88.12%   +70.12%     
===========================================
  Files         281      254       -27     
  Lines       28899    23281     -5618     
===========================================
+ Hits         5202    20517    +15315     
+ Misses      23697     2764    -20933     

see 241 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone changed the title fix(docs): remove invalid ProjectAdminOntologyAllPermission (DEV-2814) docs: remove invalid ProjectAdminOntologyAllPermission (DEV-2814) Oct 13, 2023
@seakayone seakayone changed the title docs: remove invalid ProjectAdminOntologyAllPermission (DEV-2814) docs: Remove invalid ProjectAdminOntologyAllPermission (DEV-2814) Oct 13, 2023
@jnussbaum jnussbaum merged commit 1796d52 into main Oct 13, 2023
16 checks passed
@jnussbaum jnussbaum deleted the wip/DEV-2814-remove-invalid-projectadminontologyallpermission-from-docs branch October 13, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants