Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve PR title check #2882

Merged
merged 2 commits into from Oct 16, 2023
Merged

chore: Improve PR title check #2882

merged 2 commits into from Oct 16, 2023

Conversation

seakayone
Copy link
Collaborator

Only allow upper case letters for the first letter of the actual commit.

Since all PR titles are included in the release notes the first letter of the commit message should be upper case.
This will improve the look of our release notes which are currently mixed case.

Pull Request Checklist

Task Description/Number

Issue Number: NO-TICKET

PR Type

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone marked this pull request as ready for review October 13, 2023 13:56
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (5025dc1) 23.29%.
Report is 89 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
+ Coverage   18.00%   23.29%   +5.29%     
==========================================
  Files         281      254      -27     
  Lines       28899    23281    -5618     
==========================================
+ Hits         5202     5423     +221     
+ Misses      23697    17858    -5839     

see 186 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone enabled auto-merge (squash) October 16, 2023 06:38
@seakayone seakayone merged commit 6f4b962 into main Oct 16, 2023
14 checks passed
@seakayone seakayone deleted the chore/improve-pr-titles branch October 16, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants