Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove/Fix some compiler warnings #2899

Merged
merged 2 commits into from Oct 24, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Oct 23, 2023

  • move the forkDaemon into the for comprehension when starting the instrumentation server
  • remove unused layers from ProjectsServiceLiveSpec

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Oct 23, 2023
@seakayone seakayone force-pushed the refactor/remove-compiler-warnings branch from 1dee4b0 to b79d281 Compare October 23, 2023 12:37
@seakayone seakayone changed the title refactor: Reduce compile warnings refactor: Remove/Fix some compiler warnings Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (6ce0a80) 88.04%.
Report is 107 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2899       +/-   ##
===========================================
+ Coverage   18.00%   88.04%   +70.04%     
===========================================
  Files         281      251       -30     
  Lines       28899    23070     -5829     
===========================================
+ Hits         5202    20311    +15109     
+ Misses      23697     2759    -20938     

see 261 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review October 24, 2023 07:40
@seakayone seakayone enabled auto-merge (squash) October 24, 2023 07:41
@seakayone seakayone merged commit cb5dec6 into main Oct 24, 2023
19 checks passed
@seakayone seakayone deleted the refactor/remove-compiler-warnings branch October 24, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants