Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Startup and keep instrumentation server running #2901

Merged
merged 3 commits into from Oct 24, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Oct 24, 2023

Startup and keep running after the app server is up and running

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Oct 24, 2023
@seakayone seakayone changed the title fix: Startup and keep instrumentation server running after the app se… fix: Startup and keep instrumentation server running Oct 24, 2023
@seakayone seakayone marked this pull request as ready for review October 24, 2023 11:36
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (aa9c99b) 88.04%.
Report is 108 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2901       +/-   ##
===========================================
+ Coverage   18.00%   88.04%   +70.04%     
===========================================
  Files         281      251       -30     
  Lines       28899    23070     -5829     
===========================================
+ Hits         5202    20311    +15109     
+ Misses      23697     2759    -20938     

see 261 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone enabled auto-merge (squash) October 24, 2023 11:58
@seakayone seakayone merged commit a11af40 into main Oct 24, 2023
17 checks passed
@seakayone seakayone deleted the fix/startup-instrumentation-server branch October 24, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants