Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove GitHub action which tests zio-http routes #2903

Merged
merged 2 commits into from Oct 24, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Oct 24, 2023

The dedicated zio-http routes do not exist anymore.

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Oct 24, 2023
@seakayone seakayone marked this pull request as ready for review October 24, 2023 12:09
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (e176c64) 11.65%.
Report is 109 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2903      +/-   ##
==========================================
- Coverage   18.00%   11.65%   -6.35%     
==========================================
  Files         281      251      -30     
  Lines       28899    23070    -5829     
==========================================
- Hits         5202     2688    -2514     
+ Misses      23697    20382    -3315     

see 232 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone merged commit 1999b22 into main Oct 24, 2023
14 checks passed
@seakayone seakayone deleted the chore/rm-needless-test-runs branch October 24, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants