Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump sipi version #2913

Merged

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Nov 1, 2023

Pull Request Checklist

Task Description/Number

Bump sipi version.

Issue Number: DEV-2887

PR Type

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Nov 1, 2023

DEV-2887 Add crash reporting to Sipi through Sentry.io

https://sentry.io

Sentry.io provides a c++ client that should allow us to catch and report Sipi crashes and send them to Datadog via the Sentry.io integration.

  • add sentry.io c++ sdk
  • initialize sentry in main
  • add sentry config through environment variables
  • skip sentry init if no sentry config is provided
  • bump used Sipi version in dsp-api
  • change deployment scripts to add sentry environment variables

@subotic subotic self-assigned this Nov 1, 2023
project/Dependencies.scala Show resolved Hide resolved
@seakayone seakayone changed the title deps(sipi): bump sipi version chore(sipi): Bump sipi version Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (3a57510) 11.67%.
Report is 115 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2913      +/-   ##
==========================================
- Coverage   18.00%   11.67%   -6.33%     
==========================================
  Files         281      251      -30     
  Lines       28899    23079    -5820     
==========================================
- Hits         5202     2695    -2507     
+ Misses      23697    20384    -3313     

see 232 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subotic subotic changed the title chore(sipi): Bump sipi version chore(sipi): bump sipi version Nov 1, 2023
@subotic subotic changed the title chore(sipi): bump sipi version chore: bump sipi version Nov 1, 2023
@seakayone seakayone changed the title chore: bump sipi version chore: Bump sipi version Nov 1, 2023
@subotic subotic marked this pull request as ready for review November 1, 2023 17:16
@subotic subotic merged commit 303ca0f into main Nov 1, 2023
15 of 19 checks passed
@subotic subotic deleted the feature/dev-2887-add-crash-reporting-to-sipi-through-sentryio branch November 1, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants