Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scala-steward): Improve dependency grouping #2919

Merged
merged 2 commits into from Nov 7, 2023
Merged

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Nov 6, 2023

Pull Request Checklist

Task Description/Number

Issue Number: N/A

This PR split major and minor dependency update groups. Due to breaking changes that major updates could potentially include, is better to keep them separated to minor updates.

PR Type

  • chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents a new feature
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: all about tests: adding, refactoring tests (no production code change)

Basic Requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@mpro7 mpro7 self-assigned this Nov 6, 2023
@mpro7 mpro7 requested a review from seakayone November 6, 2023 13:28
@mpro7 mpro7 marked this pull request as ready for review November 6, 2023 13:28
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (3e95d71) 11.68% compared to head (9fdfb6f) 11.69%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2919   +/-   ##
=======================================
  Coverage   11.68%   11.69%           
=======================================
  Files         251      251           
  Lines       23065    23068    +3     
=======================================
+ Hits         2695     2697    +2     
- Misses      20370    20371    +1     
Files Coverage Δ
.../slice/admin/domain/service/KnoraProjectRepo.scala 100.00% <100.00%> (ø)
...bapi/src/main/scala/dsp/valueobjects/Project.scala 86.74% <85.71%> (+0.32%) ⬆️
...ce/admin/domain/service/ProjectExportService.scala 0.00% <0.00%> (ø)
...lice/admin/repo/service/KnoraProjectRepoLive.scala 0.00% <0.00%> (ø)
...slice/admin/domain/service/ProjectADMService.scala 11.11% <19.04%> (-0.26%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 enabled auto-merge (squash) November 7, 2023 09:34
@mpro7 mpro7 merged commit dbda1cc into main Nov 7, 2023
14 checks passed
@mpro7 mpro7 deleted the scala-steward-update branch November 7, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants