Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace MessageRelay with KnoraProjectRepo in OntologyResponderV2 #2920

Merged
merged 3 commits into from Nov 8, 2023

Conversation

seakayone
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: NO-PROJECT

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Nov 7, 2023
@seakayone seakayone force-pushed the refactor/cleanup-ontologyResponder branch from 9a2dbda to 37d983e Compare November 7, 2023 10:40
@seakayone seakayone changed the title refactor: Replace messageRelay with KnoraProjectRepo in OntologyResponderV2 refactor: Replace MessageRelay with KnoraProjectRepo in OntologyResponderV2 Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (3e95d71) 11.68% compared to head (3a1fca0) 11.71%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2920      +/-   ##
==========================================
+ Coverage   11.68%   11.71%   +0.02%     
==========================================
  Files         251      248       -3     
  Lines       23065    23017      -48     
==========================================
+ Hits         2695     2696       +1     
+ Misses      20370    20321      -49     
Files Coverage Δ
.../slice/admin/domain/service/KnoraProjectRepo.scala 100.00% <100.00%> (ø)
...bapi/src/main/scala/dsp/valueobjects/Project.scala 86.74% <85.71%> (+0.32%) ⬆️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...i/slice/admin/domain/service/DspIngestClient.scala 52.00% <0.00%> (ø)
...ce/admin/domain/service/ProjectImportService.scala 9.80% <0.00%> (-1.74%) ⬇️
...ra/webapi/slice/infrastructure/MetricsServer.scala 0.00% <0.00%> (ø)
...ebapi/slice/infrastructure/api/PrometheusApp.scala 0.00% <0.00%> (ø)
...ce/admin/domain/service/ProjectExportService.scala 0.00% <0.00%> (ø)
...lice/admin/repo/service/KnoraProjectRepoLive.scala 0.00% <0.00%> (ø)
...ora/webapi/responders/v2/OntologyResponderV2.scala 0.00% <0.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone force-pushed the refactor/cleanup-ontologyResponder branch from aa748be to aa8ec1b Compare November 7, 2023 11:01
@seakayone seakayone marked this pull request as ready for review November 7, 2023 13:54
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@seakayone seakayone enabled auto-merge (squash) November 8, 2023 15:03
@seakayone seakayone merged commit b093357 into main Nov 8, 2023
14 checks passed
@seakayone seakayone deleted the refactor/cleanup-ontologyResponder branch November 8, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants