Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prepare Scala 3 compatibility by adding -Xsource:3 compiler flag #2924

Merged
merged 5 commits into from Nov 13, 2023

Conversation

seakayone
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title chore: Activate xsource 3 chore: Prepare Scala 3 compatibility by adding -Xsource:3 compiler flag Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (3e95d71) 11.68% compared to head (e48b69d) 88.48%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2924       +/-   ##
===========================================
+ Coverage   11.68%   88.48%   +76.80%     
===========================================
  Files         251      247        -4     
  Lines       23065    22922      -143     
===========================================
+ Hits         2695    20283    +17588     
+ Misses      20370     2639    -17731     
Files Coverage Δ
...ebapi/src/main/scala/dsp/constants/SalsahGui.scala 95.00% <ø> (ø)
webapi/src/main/scala/dsp/errors/Errors.scala 20.00% <ø> (+15.00%) ⬆️
...ebapi/src/main/scala/dsp/valueobjects/Schema.scala 99.04% <100.00%> (+0.95%) ⬆️
webapi/src/main/scala/dsp/valueobjects/User.scala 71.11% <ø> (+2.22%) ⬆️
...main/scala/org/knora/webapi/config/AppConfig.scala 85.29% <ø> (ø)
...main/scala/org/knora/webapi/core/ActorSystem.scala 100.00% <ø> (+100.00%) ⬆️
...c/main/scala/org/knora/webapi/core/AppRouter.scala 100.00% <ø> (+100.00%) ⬆️
...c/main/scala/org/knora/webapi/core/AppServer.scala 91.30% <ø> (+91.30%) ⬆️
.../main/scala/org/knora/webapi/core/HttpServer.scala 100.00% <ø> (+100.00%) ⬆️
...ain/scala/org/knora/webapi/core/MessageRelay.scala 100.00% <ø> (ø)
... and 173 more

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone self-assigned this Nov 10, 2023
@seakayone seakayone changed the base branch from main to chore/cleanup November 10, 2023 13:24
@seakayone seakayone changed the base branch from chore/cleanup to main November 10, 2023 14:50
@seakayone seakayone marked this pull request as ready for review November 10, 2023 17:32
@seakayone seakayone merged commit ff9df5f into main Nov 13, 2023
14 checks passed
@seakayone seakayone deleted the chore/activate-xsource-3 branch November 13, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants