Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use KnoraRepo instead of MessageRelay in ResourcesResponderV2 #2927

Merged
merged 2 commits into from Nov 14, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Nov 14, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Nov 14, 2023
@seakayone seakayone marked this pull request as ready for review November 14, 2023 09:14
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff9df5f) 11.63% compared to head (b424d48) 86.64%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2927       +/-   ##
===========================================
+ Coverage   11.63%   86.64%   +75.00%     
===========================================
  Files         247      247               
  Lines       22922    22923        +1     
===========================================
+ Hits         2668    19861    +17193     
+ Misses      20254     3062    -17192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone force-pushed the refactor/use-KnoraProjectRepo-in-ResourcesResponderV2 branch 2 times, most recently from b5d6b96 to 8b9f4cc Compare November 14, 2023 10:49
@seakayone seakayone force-pushed the refactor/use-KnoraProjectRepo-in-ResourcesResponderV2 branch from 8b9f4cc to 0563cbe Compare November 14, 2023 10:50
@seakayone seakayone merged commit 2358f23 into main Nov 14, 2023
14 checks passed
@seakayone seakayone deleted the refactor/use-KnoraProjectRepo-in-ResourcesResponderV2 branch November 14, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants