Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify and rename SipiService #2929

Merged
merged 8 commits into from Nov 15, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Nov 14, 2023

Pull Request Checklist

Task Description/Number

Issue Number: NO-TICKET

Removes GetFileMetadataRequest and respective GetFileMetadataResponse using the response from Sipi instead.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ff9df5f) 11.63% compared to head (937e76f) 88.48%.
Report is 2 commits behind head on main.

Files Patch % Lines
.../org/knora/webapi/store/iiif/api/SipiService.scala 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2929       +/-   ##
===========================================
+ Coverage   11.63%   88.48%   +76.84%     
===========================================
  Files         247      246        -1     
  Lines       22922    22906       -16     
===========================================
+ Hits         2668    20268    +17600     
+ Misses      20254     2638    -17616     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review November 15, 2023 13:30
@seakayone seakayone requested a review from mpro7 November 15, 2023 13:34
@seakayone seakayone merged commit 0835301 into main Nov 15, 2023
15 checks passed
@seakayone seakayone deleted the refactor/simplify-IIIFService branch November 15, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants