Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove duplicate 'gravsearch' metrics #2936

Merged
merged 6 commits into from Nov 15, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Nov 15, 2023

Relates to DEV-2151

The removes metrics which are redundant since the introduction of fuseki_request_duration metric.

Collecting the metrics is removed in https://github.com/dasch-swiss/ops-deploy/pull/560

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Nov 15, 2023
@seakayone seakayone changed the title chore: Remove 'gravsearch' metrics chore: Remove duplicate 'gravsearch' metrics Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (ff9df5f) 11.63% compared to head (da6b59b) 11.65%.
Report is 6 commits behind head on main.

Files Patch % Lines
...s/v2/responder/valuemessages/ValueMessagesV2.scala 0.00% 22 Missing ⚠️
.../org/knora/webapi/store/iiif/api/SipiService.scala 0.00% 6 Missing ⚠️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 0.00% 4 Missing ⚠️
...knora/webapi/store/iiif/impl/SipiServiceLive.scala 0.00% 3 Missing ⚠️
...c/main/scala/org/knora/webapi/core/AppServer.scala 0.00% 2 Missing ⚠️
...vsearch/prequery/GravsearchQueryOptimisation.scala 0.00% 2 Missing ⚠️
...ora/webapi/responders/admin/SipiResponderADM.scala 0.00% 2 Missing ⚠️
...org/knora/webapi/routing/admin/FilesRouteADM.scala 0.00% 2 Missing ⚠️
...la/org/knora/webapi/routing/v2/SearchRouteV2.scala 0.00% 2 Missing ⚠️
.../webapi/store/iiif/IIIFRequestMessageHandler.scala 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2936      +/-   ##
==========================================
+ Coverage   11.63%   11.65%   +0.01%     
==========================================
  Files         247      246       -1     
  Lines       22922    22883      -39     
==========================================
- Hits         2668     2666       -2     
+ Misses      20254    20217      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review November 15, 2023 16:09
@seakayone seakayone enabled auto-merge (squash) November 15, 2023 16:09
@seakayone seakayone merged commit f11dfef into main Nov 15, 2023
14 checks passed
@seakayone seakayone deleted the refactor/cleanup-gravsearch-metrics branch November 15, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants