Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move ProjectIri to KnoraProject #2944

Merged
merged 11 commits into from Nov 20, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Nov 17, 2023

Pull Request Checklist

Task Description/Number

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 150 lines in your changes are missing coverage. Please review.

Comparison is base (ef714c1) 11.64% compared to head (597cf9b) 11.63%.
Report is 6 commits behind head on main.

❗ Current head 597cf9b differs from pull request most recent head 2f4d885. Consider uploading reports for the commit 2f4d885 to get more accurate results

Files Patch % Lines
...knora/webapi/responders/v2/SearchResponderV2.scala 0.00% 57 Missing ⚠️
...ra/webapi/responders/admin/ListsResponderADM.scala 0.00% 21 Missing ⚠️
...la/org/knora/webapi/routing/v2/SearchRouteV2.scala 0.00% 19 Missing ⚠️
...lice/admin/repo/service/KnoraProjectRepoLive.scala 0.00% 13 Missing ⚠️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 0.00% 8 Missing ⚠️
...ch/gravsearch/transformers/SparqlTransformer.scala 14.28% 6 Missing ⚠️
...org/knora/webapi/responders/v2/SearchQueries.scala 0.00% 5 Missing ⚠️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 0.00% 5 Missing ⚠️
...knora/webapi/responders/v2/ValuesResponderV2.scala 0.00% 4 Missing ⚠️
...c/main/scala/org/knora/webapi/OntologySchema.scala 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2944      +/-   ##
==========================================
- Coverage   11.64%   11.63%   -0.02%     
==========================================
  Files         246      246              
  Lines       22885    22862      -23     
==========================================
- Hits         2666     2661       -5     
+ Misses      20219    20201      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review November 20, 2023 09:34
@seakayone seakayone force-pushed the refactor/move-ProjectIri-toKnoraProject branch from 52e2448 to 6ac5627 Compare November 20, 2023 11:50
@seakayone seakayone enabled auto-merge (squash) November 20, 2023 17:08
@seakayone seakayone merged commit af95516 into main Nov 20, 2023
12 checks passed
@seakayone seakayone deleted the refactor/move-ProjectIri-toKnoraProject branch November 20, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants