Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Sipi version to 3.8.6 #2947

Merged
merged 1 commit into from Nov 19, 2023

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Nov 18, 2023

Pull Request Checklist

Task Description/Number

relates to: INFRA-455

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Nov 18, 2023

INFRA-455 Reduce SIPI logging

SIPI is logging excessively; probably from Sentry?
If not addressed we might exceed our log budget on DataDog.

@subotic subotic self-assigned this Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ef714c1) 11.64% compared to head (de7e4c5) 88.50%.
Report is 2 commits behind head on main.

Files Patch % Lines
...org/knora/webapi/responders/v2/SearchQueries.scala 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2947       +/-   ##
===========================================
+ Coverage   11.64%   88.50%   +76.85%     
===========================================
  Files         246      247        +1     
  Lines       22885    22878        -7     
===========================================
+ Hits         2666    20249    +17583     
+ Misses      20219     2629    -17590     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subotic subotic merged commit 34b74bf into main Nov 19, 2023
14 checks passed
@subotic subotic deleted the feature/infra-455-reduce-sipi-logging-2 branch November 19, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants