New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Invalidate cached project information when adding an ontology to a project (DEV-2926) #2949
Merged
BalduinLandolt
merged 7 commits into
main
from
feature/dev-2926-on-localhost-adminprojects-routes-dont-return-the-ontologies
Nov 22, 2023
Merged
fix: Invalidate cached project information when adding an ontology to a project (DEV-2926) #2949
BalduinLandolt
merged 7 commits into
main
from
feature/dev-2926-on-localhost-adminprojects-routes-dont-return-the-ontologies
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2926 on localhost, /admin/projects routes don't return the ontologies
The following requests return incomplete information:
Steps to reproduce
The same request on a server works correctly: GET https://api.demo.dasch.swiss/admin/projects/shortname/rosetta
Severity / affected usersLow severity, probably no users affected, but blocks DEV-2921 (DSP-TOOLS) |
BalduinLandolt
changed the title
fix: after creating an ontology, the project endpoint doesn't return it because the cache is not invalidated (DEV-2926)
fix: After creating an ontology, the project endpoint doesn't return it because the cache is not invalidated (DEV-2926)
Nov 21, 2023
mpro7
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, just 2 minor comments:
integration/src/test/scala/org/knora/webapi/responders/v2/OntologyResponderV2Spec.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cache/impl/CacheServiceInMemImpl.scala
Outdated
Show resolved
Hide resolved
BalduinLandolt
changed the title
fix: After creating an ontology, the project endpoint doesn't return it because the cache is not invalidated (DEV-2926)
fix: Invalidate cached project information when adding an ontology to a project (DEV-2926)
Nov 22, 2023
Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
BalduinLandolt
deleted the
feature/dev-2926-on-localhost-adminprojects-routes-dont-return-the-ontologies
branch
November 22, 2023 12:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?