Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use sttpbackend and reuse access token if not expired #2968

Merged
merged 3 commits into from Dec 19, 2023

Conversation

seakayone
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Dec 19, 2023
@seakayone seakayone changed the title refactor: Use sttpbackend refactor: Use sttpbackend and reuse access token if not expired Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (95ad2f9) 11.62% compared to head (5496a1a) 88.52%.

Files Patch % Lines
...i/slice/admin/domain/service/DspIngestClient.scala 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2968       +/-   ##
===========================================
+ Coverage   11.62%   88.52%   +76.89%     
===========================================
  Files         246      246               
  Lines       22870    22875        +5     
===========================================
+ Hits         2658    20249    +17591     
+ Misses      20212     2626    -17586     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review December 19, 2023 14:05
@seakayone seakayone enabled auto-merge (squash) December 19, 2023 14:06
@seakayone seakayone merged commit eac470a into main Dec 19, 2023
17 checks passed
@seakayone seakayone deleted the refactor/use-sttpbackend branch December 19, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants