Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove remaining API V1 documentation (DEV-3073) #2970

Merged
merged 3 commits into from Dec 20, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Dec 19, 2023

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (95ad2f9) 11.62% compared to head (0347357) 88.56%.
Report is 3 commits behind head on main.

Files Patch % Lines
...s/v2/responder/valuemessages/ValueMessagesV2.scala 98.24% 1 Missing ⚠️
...i/slice/admin/domain/service/DspIngestClient.scala 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2970       +/-   ##
===========================================
+ Coverage   11.62%   88.56%   +76.94%     
===========================================
  Files         246      246               
  Lines       22870    22907       +37     
===========================================
+ Hits         2658    20288    +17630     
+ Misses      20212     2619    -17593     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) December 20, 2023 09:30
@BalduinLandolt BalduinLandolt merged commit 2d3d4c4 into main Dec 20, 2023
16 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-3073-dsp-api-remove-v1-docs branch December 20, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants