feat: Add dsp ingest asset info resolution (DEV-3147) #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: AssetId): Task[AssetInfoResponse] to DspIngestClient
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2973 +/- ##
===========================================
+ Coverage 11.74% 88.57% +76.82%
===========================================
Files 246 249 +3
Lines 22907 22934 +27
===========================================
+ Hits 2690 20313 +17623
+ Misses 20217 2621 -17596 ☔ View full report in Codecov by Sentry. |
seakayone
force-pushed
the
feat/add-dsp-ingest-asset-info-resolution
branch
from
e16e2ce
to
4548a35
Compare
seakayone
force-pushed
the
feat/add-dsp-ingest-asset-info-resolution
branch
from
4548a35
to
98ccfc3
Compare
seakayone
requested review from
mpro7 and
BalduinLandolt
and removed request for
mpro7
seakayone
changed the title
BalduinLandolt
approved these changes
Jan 4, 2024
integration/src/test/scala/org/knora/webapi/config/AppConfigForTestContainers.scala
Outdated
Show resolved
Hide resolved
integration/src/test/scala/org/knora/webapi/testcontainers/DspIngestTestContainer.scala
Show resolved
Hide resolved
integration/src/test/scala/org/knora/webapi/testcontainers/TestContainerOps.scala
Outdated
Show resolved
Hide resolved
mpro7
approved these changes
Jan 5, 2024
webapi/src/main/scala/org/knora/webapi/store/iiif/api/SipiService.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/store/iiif/api/SipiService.scala
Outdated
Show resolved
Hide resolved
…tContainerOps.scala Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
…rTestContainers.scala Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
…ice.scala Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?