Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to Java 21 and remove usage of Java 17 (DEV-3146) #2974

Merged
merged 1 commit into from Dec 28, 2023

Conversation

seakayone
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Dec 27, 2023
@seakayone seakayone changed the title chore: Migrate to Java 21 and remove usage of Java 17 chore: Migrate to Java 21 and remove usage of Java 17 (DEV-2815) Dec 27, 2023
Copy link

linear bot commented Dec 27, 2023

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (1a477d1) 88.54%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ra/webapi/responders/admin/UsersResponderADM.scala 0.00% 1 Missing ⚠️
.../slice/admin/api/service/UsersADMRestService.scala 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2974       +/-   ##
===========================================
+ Coverage   11.74%   88.54%   +76.79%     
===========================================
  Files         246      249        +3     
  Lines       22907    22917       +10     
===========================================
+ Hits         2690    20291    +17601     
+ Misses      20217     2626    -17591     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone changed the title chore: Migrate to Java 21 and remove usage of Java 17 (DEV-2815) chore: Migrate to Java 21 and remove usage of Java 17 (DEV-3146) Dec 27, 2023
Copy link

linear bot commented Dec 27, 2023

@seakayone seakayone marked this pull request as ready for review December 27, 2023 20:43
@seakayone seakayone merged commit 779fddb into main Dec 28, 2023
15 checks passed
@seakayone seakayone deleted the chore/update-Java-21 branch December 28, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants