refactor: Unify user value objects and validation (DEV-3155) #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
==========================================
- Coverage 11.74% 11.60% -0.14%
==========================================
Files 246 255 +9
Lines 22907 22989 +82
==========================================
- Hits 2690 2669 -21
- Misses 20217 20320 +103 ☔ View full report in Codecov by Sentry. |
BalduinLandolt
changed the title
seakayone
requested changes
Jan 10, 2024
webapi/src/test/scala/org/knora/webapi/slice/admin/domain/model/UserSpec.scala
Outdated
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/slice/admin/domain/model/UserSpec.scala
Outdated
Show resolved
Hide resolved
mpro7
approved these changes
Jan 10, 2024
Comment on lines
33
to
39
| import org.knora.webapi.slice.admin.domain.model.Email | ||
| import org.knora.webapi.slice.admin.domain.model.FamilyName | ||
| import org.knora.webapi.slice.admin.domain.model.GivenName | ||
| import org.knora.webapi.slice.admin.domain.model.Password | ||
| import org.knora.webapi.slice.admin.domain.model.SystemAdmin | ||
| import org.knora.webapi.slice.admin.domain.model.UserStatus | ||
| import org.knora.webapi.slice.admin.domain.model.Username |
There was a problem hiding this comment.
Suggested change
| import org.knora.webapi.slice.admin.domain.model.Email | |
| import org.knora.webapi.slice.admin.domain.model.FamilyName | |
| import org.knora.webapi.slice.admin.domain.model.GivenName | |
| import org.knora.webapi.slice.admin.domain.model.Password | |
| import org.knora.webapi.slice.admin.domain.model.SystemAdmin | |
| import org.knora.webapi.slice.admin.domain.model.UserStatus | |
| import org.knora.webapi.slice.admin.domain.model.Username | |
| import org.knora.webapi.slice.admin.domain.model.* |
Comment on lines
44
to
49
| import org.knora.webapi.slice.admin.domain.model.Email | ||
| import org.knora.webapi.slice.admin.domain.model.Password | ||
| import org.knora.webapi.slice.admin.domain.model.SystemAdmin | ||
| import org.knora.webapi.slice.admin.domain.model.User | ||
| import org.knora.webapi.slice.admin.domain.model.UserStatus | ||
| import org.knora.webapi.slice.admin.domain.model.Username |
There was a problem hiding this comment.
Suggested change
| import org.knora.webapi.slice.admin.domain.model.Email | |
| import org.knora.webapi.slice.admin.domain.model.Password | |
| import org.knora.webapi.slice.admin.domain.model.SystemAdmin | |
| import org.knora.webapi.slice.admin.domain.model.User | |
| import org.knora.webapi.slice.admin.domain.model.UserStatus | |
| import org.knora.webapi.slice.admin.domain.model.Username | |
| import org.knora.webapi.slice.admin.domain.model.* |
seakayone
approved these changes
Jan 10, 2024
BalduinLandolt
deleted the
feature/dev-3155-streamline-user-identifier-objects-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?