Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate getAllGroups route to tapir (DEV-1588) #2984

Merged
merged 13 commits into from Jan 9, 2024

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Jan 9, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1588

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@mpro7 mpro7 self-assigned this Jan 9, 2024
Copy link

linear bot commented Jan 9, 2024

Copy link

swarmia bot commented Jan 9, 2024

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (a23e992) 11.68%.
Report is 12 commits behind head on main.

❗ Current head a23e992 differs from pull request most recent head 36058d1. Consider uploading reports for the commit 36058d1 to get more accurate results

Files Patch % Lines
webapi/src/main/scala/dsp/valueobjects/User.scala 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2984      +/-   ##
==========================================
- Coverage   11.74%   11.68%   -0.06%     
==========================================
  Files         246      256      +10     
  Lines       22907    23022     +115     
==========================================
+ Hits         2690     2691       +1     
- Misses      20217    20331     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@seakayone seakayone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your new tapir endpoints to the org.knora.webapi.slice.admin.api.AdminApiEndpoints.

@seakayone seakayone self-requested a review January 9, 2024 16:30
@mpro7 mpro7 enabled auto-merge (squash) January 9, 2024 16:38
@mpro7 mpro7 merged commit e5285ea into main Jan 9, 2024
11 checks passed
@mpro7 mpro7 deleted the dev-1588-dsp-api-migrate-admingroups-routes-to-tapir branch January 9, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants