Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change RDF handling for querying Projects from DB (DEV-3175) #2989

Merged
merged 56 commits into from Feb 6, 2024

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Jan 10, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (2e29b1c) 11.60%.
Report is 51 commits behind head on main.

❗ Current head 2e29b1c differs from pull request most recent head db90508. Consider uploading reports for the commit db90508 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
- Coverage   11.74%   11.60%   -0.14%     
==========================================
  Files         246      260      +14     
  Lines       22907    22929      +22     
==========================================
- Hits         2690     2661      -29     
- Misses      20217    20268      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt changed the title [DO NOT MERGE] Wip/improve rdf handling [DO NOT MERGE] Wip/improve rdf handling (DEV-3175) Jan 16, 2024
Copy link

linear bot commented Jan 16, 2024

@BalduinLandolt BalduinLandolt marked this pull request as ready for review February 6, 2024 09:06
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I was introduced to this by Balduin.)

Copy link
Collaborator

@seakayone seakayone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have just had some minor note for improving this, please address them before merging.

@seakayone seakayone self-requested a review February 6, 2024 12:19
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have one question, not sure if important, but please address it before merge:

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) February 6, 2024 14:47
@BalduinLandolt BalduinLandolt merged commit 884e3a8 into main Feb 6, 2024
11 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/improve-rdf-handling branch February 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants