Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow all mime types in API that are returned by Ingest (DEV-3163) #2994

Merged
merged 1 commit into from Jan 16, 2024

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Jan 16, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-3163

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Jan 16, 2024

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (67a7e11) 88.55%.
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2994       +/-   ##
===========================================
+ Coverage   11.74%   88.55%   +76.81%     
===========================================
  Files         246      255        +9     
  Lines       22907    23087      +180     
===========================================
+ Hits         2690    20445    +17755     
+ Misses      20217     2642    -17575     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the lists alphabetically sorted, but it's just me :P

@BalduinLandolt BalduinLandolt merged commit 1ea69a4 into main Jan 16, 2024
14 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/fix-decrepancies-in-mime-types branch January 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants