Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): Use just targets instead of make targets #3000

Merged
merged 4 commits into from Jan 29, 2024

Conversation

jnussbaum
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@jnussbaum jnussbaum self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (8f6ac2c) 88.56%.
Report is 30 commits behind head on main.

❗ Current head 8f6ac2c differs from pull request most recent head 682965a. Consider uploading reports for the commit 682965a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3000       +/-   ##
===========================================
+ Coverage   11.74%   88.56%   +76.82%     
===========================================
  Files         246      259       +13     
  Lines       22907    23083      +176     
===========================================
+ Hits         2690    20444    +17754     
+ Misses      20217     2639    -17578     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Show resolved Hide resolved
@seakayone seakayone enabled auto-merge (squash) January 29, 2024 08:49
@seakayone seakayone merged commit 71e6119 into main Jan 29, 2024
11 checks passed
@seakayone seakayone deleted the chore/readme-use-just branch January 29, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants