New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable UpgradePlugin
s to restrict to a specific graph and update the knora base version to 26
#3005
feat: Enable UpgradePlugin
s to restrict to a specific graph and update the knora base version to 26
#3005
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
===========================================
+ Coverage 11.74% 88.50% +76.76%
===========================================
Files 246 263 +17
Lines 22907 23099 +192
===========================================
+ Hits 2690 20444 +17754
+ Misses 20217 2655 -17562 ☔ View full report in Codecov by Sentry. |
02e71d6
to
4b4576c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update, it looks promising! Although I approve it please wait in this case for all reviewers feedback.
webapi/src/main/scala/org/knora/webapi/store/triplestore/impl/TriplestoreServiceLive.scala
Show resolved
Hide resolved
…oreServiceLive#downloadRepository
I appreciate your review, have you been able to test this out locally? |
Yes, repository upgrade test passed locally. |
UpgradePlugin
s to restrict to a specific graph and update the knora base version to 26
@jnussbaum FYI - my guess is that symlinks will not work over github, so it's probably best to change it in TOOLS right away when this is merged. (And RDU will then have to update their DSP-TOOLS version, I suppose.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, I like the changes and I'm looking forward to continue improving the plugin situation, but this takes away the immediate pressure, which is great!
@BalduinLandolt So if I get you right, we have to modify our URLs as follows:
|
Looks right, but I would suggest quickly testing it to verify, once this is merged, just to be sure. |
Pull Request Checklist
Task Description/Number
This PR allows an
UpgradePlugin
to confine its changes to a specific set of graphs. This speed up the upgrade process substantially. IfUpgradePlugins
only need to update the builtIn ontology graphs there is no need to drop all other ontology or data graphs.Moves
knora-ontologies
towebapi/src/main/resources/knora-ontologies
in order to make the ontologies part of the classpath. This is necessary for local development in order to run theUpgradePlugins
locally. Hence, we can remove adding them to the container manually. Retains a symbolic link on the root level of this repo so that other scripts and test code still can find them. Cleaning this up is left for a followup issue in order to keep the size of this PR manageable.Replaces
NoopPlugin
with a more adequately namedMigrateOnlyBuiltInGraphs
. This plugin is updating the builtIn graphs (i.e. the ones found inknora-ontologies
) once applied.Upgrades the knora base version to
26
and applies above migration plugin in order to update the builtIn graphs to the latest version.PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?