refactor: Migrate update and delete of lists to Tapir #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
changed the base branch from
main
to
refactor/migrate-get-lists-to-tapir
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3013 +/- ##
===========================================
+ Coverage 11.74% 88.42% +76.68%
===========================================
Files 246 260 +14
Lines 22907 22951 +44
===========================================
+ Hits 2690 20295 +17605
+ Misses 20217 2656 -17561 ☔ View full report in Codecov by Sentry. |
seakayone
changed the title
PUT /admin/lists/** to tapir
seakayone
changed the title
PUT /admin/lists/** to tapir
seakayone
force-pushed
the
refactor/migrate-update-lists-to-tapir
branch
from
6917e63
to
9d9a8a2
Compare
mpro7
approved these changes
Feb 2, 2024
webapi/src/main/scala/org/knora/webapi/slice/admin/api/ListsEndpointsHandlers.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
based on #3012 which has to be merged first.
Migrates update and delete related
/admin/listsendpoints to Tapir, includingPUT /admin/lists/**DELETE /admin/lists/**PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?