Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Less information in auth error messages (DEV-3260) #3019

Merged
merged 3 commits into from Feb 5, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Feb 2, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-3260

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Feb 2, 2024

@siers siers force-pushed the fix/authentication-secure-errors branch from d06a666 to 9e7fb1f Compare February 2, 2024 13:04
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (fe71048) 88.42%.
Report is 42 commits behind head on main.

❗ Current head fe71048 differs from pull request most recent head 579dcab. Consider uploading reports for the commit 579dcab to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3019       +/-   ##
===========================================
+ Coverage   11.74%   88.42%   +76.68%     
===========================================
  Files         246      260       +14     
  Lines       22907    22949       +42     
===========================================
+ Hits         2690    20293    +17603     
+ Misses      20217     2656    -17561     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siers siers self-assigned this Feb 2, 2024
@siers siers enabled auto-merge (squash) February 5, 2024 09:40
@siers siers merged commit 569a6c1 into main Feb 5, 2024
11 checks passed
@siers siers deleted the fix/authentication-secure-errors branch February 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants