chore: Remove jodd dependency (DEV-3069) #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
===========================================
+ Coverage 11.74% 88.51% +76.77%
===========================================
Files 246 258 +12
Lines 22907 22846 -61
===========================================
+ Hits 2690 20223 +17533
+ Misses 20217 2623 -17594 ☔ View full report in Codecov by Sentry. |
BalduinLandolt
approved these changes
Feb 6, 2024
siers
force-pushed
the
fix/remove-jodd
branch
from
41ffc9a
to
0e45b5c
Compare
seakayone
requested changes
Feb 6, 2024
There was a problem hiding this comment.
For the time zone you have choosen the ZoneId.systemDefault().
This will actually depend on the servers settings. IMHO it would be better to replace this with a private val utc = ZoneId.of("UTC") for both places.
I have tested this out locally and the tests still pass.
This would make the code independent of external settings.
webapi/src/main/scala/org/knora/webapi/messages/util/DateUtil.scala
Outdated
Show resolved
Hide resolved
mpro7
approved these changes
Feb 6, 2024
webapi/src/main/scala/org/knora/webapi/messages/util/DateUtil.scala
Outdated
Show resolved
Hide resolved
Java's implementation uses an days starting at midnight, not at noon, thankfully.
siers
force-pushed
the
fix/remove-jodd
branch
from
0e45b5c
to
9028ef7
Compare
seakayone
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java's implementation uses an days starting at midnight, not at noon, thankfully. JulianFields docs
The tests seem to be good and failed when appropriate, so I have confidence in this change.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?