New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove cardinality restriction for comments on regions (DEV-3179) #3026
fix: Remove cardinality restriction for comments on regions (DEV-3179) #3026
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3026 +/- ##
==========================================
- Coverage 11.74% 11.33% -0.41%
==========================================
Files 246 258 +12
Lines 22907 22849 -58
==========================================
- Hits 2690 2590 -100
- Misses 20217 20259 +42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check if there are tests that require min. comments amount?
Functionally it doesn't break anything (I widened the cardinality, so no previous state should be illegal), but tests need fixing, still... |
…ion-for-comments-on-regions
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?