Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove cardinality restriction for comments on regions (DEV-3179) #3026

Conversation

BalduinLandolt
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Feb 6, 2024
Copy link

linear bot commented Feb 6, 2024

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (3e1e67f) 11.33%.
Report is 52 commits behind head on main.

❗ Current head 3e1e67f differs from pull request most recent head 8ad7ea8. Consider uploading reports for the commit 8ad7ea8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3026      +/-   ##
==========================================
- Coverage   11.74%   11.33%   -0.41%     
==========================================
  Files         246      258      +12     
  Lines       22907    22849      -58     
==========================================
- Hits         2690     2590     -100     
- Misses      20217    20259      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if there are tests that require min. comments amount?

@BalduinLandolt
Copy link
Collaborator Author

Did you check if there are tests that require min. comments amount?

Functionally it doesn't break anything (I widened the cardinality, so no previous state should be illegal), but tests need fixing, still...

@BalduinLandolt BalduinLandolt merged commit 9ea8d6e into main Feb 6, 2024
11 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-3179-remove-cardinality-restriction-for-comments-on-regions branch February 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants