Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove jodd dependency leftovers #3028

Merged
merged 3 commits into from Feb 7, 2024
Merged

chore: Remove jodd dependency leftovers #3028

merged 3 commits into from Feb 7, 2024

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Feb 6, 2024

Pull Request Checklist

Task Description/Number

I just remind myself that we had jodd added to update exceptions. It most probably wouldn't break anything, but I removed it just to be on the safe side.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@mpro7 mpro7 self-assigned this Feb 6, 2024
@mpro7 mpro7 marked this pull request as ready for review February 6, 2024 14:52
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (f7a5b6d) 88.55%.
Report is 53 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3028       +/-   ##
===========================================
+ Coverage   11.74%   88.55%   +76.81%     
===========================================
  Files         246      260       +14     
  Lines       22907    22930       +23     
===========================================
+ Hits         2690    20306    +17616     
+ Misses      20217     2624    -17593     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you!

@mpro7 mpro7 enabled auto-merge (squash) February 7, 2024 07:17
@mpro7
Copy link
Collaborator Author

mpro7 commented Feb 7, 2024

Oops, thank you!

All good, you are welcome. You couldn't know about that. Of course you could search across the repo for what is removed, which is good habit anyway, but you just started :)

@mpro7 mpro7 merged commit 21a4c83 into main Feb 7, 2024
13 checks passed
@mpro7 mpro7 deleted the jodd-leftovers branch February 7, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants