Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove kamon (DEV-3261) #3030

Merged
merged 2 commits into from Feb 8, 2024
Merged

chore: Remove kamon (DEV-3261) #3030

merged 2 commits into from Feb 8, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Feb 7, 2024

Turns out InstrumentationSupport was almost all dead code, other than the two lines I inlined in AroundDirectives.

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@siers siers self-assigned this Feb 7, 2024
Copy link

linear bot commented Feb 7, 2024

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (2ffd702) 88.62%.
Report is 56 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3030       +/-   ##
===========================================
+ Coverage   11.74%   88.62%   +76.88%     
===========================================
  Files         246      259       +13     
  Lines       22907    22859       -48     
===========================================
+ Hits         2690    20259    +17569     
+ Misses      20217     2600    -17617     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning it up :)

@siers siers merged commit f27f118 into main Feb 8, 2024
13 checks passed
@siers siers deleted the chore/remove-kamon branch February 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants