Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove UUID version check from IRI value objects (DEV-3310) #3033

Merged
merged 17 commits into from Feb 22, 2024

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Feb 8, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-3310

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (582cacf) 88.57%.
Report is 77 commits behind head on main.

Files Patch % Lines
webapi/src/main/scala/dsp/valueobjects/Iri.scala 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3033       +/-   ##
===========================================
+ Coverage   11.74%   88.57%   +76.83%     
===========================================
  Files         246      263       +17     
  Lines       22907    22647      -260     
===========================================
+ Hits         2690    20060    +17370     
+ Misses      20217     2587    -17630     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 self-assigned this Feb 13, 2024
@mpro7 mpro7 marked this pull request as ready for review February 21, 2024 10:05
@mpro7 mpro7 changed the title refactor: Remove UUID version check from IRI value objects refactor: Remove UUID version check from IRI value objects (DEV-3310) Feb 21, 2024
Copy link

linear bot commented Feb 21, 2024

@mpro7 mpro7 changed the title refactor: Remove UUID version check from IRI value objects (DEV-3310) fix: Remove UUID version check from IRI value objects (DEV-3310) Feb 21, 2024
@mpro7 mpro7 merged commit 6de0374 into main Feb 22, 2024
13 checks passed
@mpro7 mpro7 deleted the remove-uuid-version-check-from-iri-validation branch February 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants