Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate users endpoints to tapir (BasicInformation, Status, Password) #3043

Merged

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Feb 13, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone marked this pull request as draft February 13, 2024 12:12
@seakayone seakayone self-assigned this Feb 13, 2024
@seakayone seakayone changed the base branch from main to refactor/introduce-user-repo February 13, 2024 12:13
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (83f9276) 88.74%.
Report is 66 commits behind head on main.

Files Patch % Lines
...src/main/scala/dsp/valueobjects/LanguageCode.scala 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3043       +/-   ##
===========================================
+ Coverage   11.74%   88.74%   +77.00%     
===========================================
  Files         246      262       +16     
  Lines       22907    22772      -135     
===========================================
+ Hits         2690    20210    +17520     
+ Misses      20217     2562    -17655     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from refactor/introduce-user-repo to main February 13, 2024 14:06
@seakayone seakayone force-pushed the refactor/migrate-users-endpoint-to-tapir-BasicUserInformation branch from 8167d42 to 6522a18 Compare February 13, 2024 15:49
@seakayone seakayone requested review from BalduinLandolt, mpro7 and siers and removed request for BalduinLandolt February 13, 2024 16:57
@seakayone seakayone marked this pull request as ready for review February 13, 2024 16:57
@seakayone seakayone changed the title refactor: Migrate users endpoint to tapir / BasicUserInformation refactor: Migrate users endpoints to tapir (BasicInformation, SystemAdmin, Status, Password) Feb 14, 2024
@seakayone seakayone changed the title refactor: Migrate users endpoints to tapir (BasicInformation, SystemAdmin, Status, Password) refactor: Migrate users endpoints to tapir (BasicInformation, Status, Password) Feb 14, 2024
@seakayone seakayone merged commit 6e16782 into main Feb 14, 2024
15 checks passed
@seakayone seakayone deleted the refactor/migrate-users-endpoint-to-tapir-BasicUserInformation branch February 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants