Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add option to make warnings non-fatal locally. #3044

Merged
merged 2 commits into from Feb 15, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Feb 14, 2024

This PR makes -Xfatal-warnings ergonomically disableable locally.

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@siers siers self-assigned this Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (e3edf42) 11.99%.
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
+ Coverage   11.74%   11.99%   +0.24%     
==========================================
  Files         246      262      +16     
  Lines       22907    22739     -168     
==========================================
+ Hits         2690     2727      +37     
+ Misses      20217    20012     -205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siers siers requested review from BalduinLandolt, mpro7 and seakayone and removed request for BalduinLandolt February 14, 2024 15:49
@seakayone
Copy link
Collaborator

Works great, thanks.

@seakayone
Copy link
Collaborator

Works great, thanks.

There is only a small problem when switching branches:

❯ git update-index --skip-worktree project/LocalSettings.scala                                                                                                                                                                                  
❯ git status                                                                                                                                                                                                                                    
On branch chore/sbt-local-settings
Your branch is up to date with 'origin/chore/sbt-local-settings'.

nothing to commit, working tree clean
❯ git checkout main                                                                                                                                                                                                                             
error: Your local changes to the following files would be overwritten by checkout:
        project/LocalSettings.scala
Please commit your changes or stash them before you switch branches.
Aborting

In order to be able to switch the branch I had to do:
git update-index --no-skip-worktree project/LocalSettings.scala

Is there an easier way, would assume-unchanged work better?

@siers
Copy link
Contributor Author

siers commented Feb 14, 2024 via email

@siers siers enabled auto-merge (squash) February 15, 2024 09:01
@siers siers merged commit 0d2367e into main Feb 15, 2024
13 checks passed
@siers siers deleted the chore/sbt-local-settings branch February 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants