Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate user group endpoints to Tapir and remove UserRouteADM #3046

Merged
merged 12 commits into from Feb 15, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Feb 14, 2024

  • Add ensureSystemAdminOrProjectAdmin(User, ProjectIri) to AuthorizationRestService
  • Migrate PUT /admin/users/iri/<userIri>/SystemAdmin to Tapir
  • Migrate POST /admin/users/iri/<userIri>/project-memberships/<projectIri> to Tapir
  • Migrate DELETE /admin/users/iri/<userIri>/project-memberships/<projectIri> to Tapir
  • Migrate POST /admin/users/iri/<userIri>/project-admin-memberships/<projectIri> to Tapir
  • Migrate DELETE /admin/users/iri/<userIri>/project-admin-memberships/<projectIri> to Tapir
  • Migrate POST /admin/users/iri/<userIri>/group-memberships/<groupIri> to Tapir
  • Migrate DELETE /admin/users/iri/<userIri>/group-memberships/<groupIri> to Tapir
  • Remove UsersRouteADM

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (89aa9dd) 11.99%.
Report is 69 commits behind head on main.

Files Patch % Lines
...src/main/scala/dsp/valueobjects/LanguageCode.scala 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3046      +/-   ##
==========================================
+ Coverage   11.74%   11.99%   +0.24%     
==========================================
  Files         246      262      +16     
  Lines       22907    22739     -168     
==========================================
+ Hits         2690     2727      +37     
+ Misses      20217    20012     -205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone requested review from mpro7, BalduinLandolt and siers and removed request for mpro7 February 15, 2024 07:51
@seakayone seakayone enabled auto-merge (squash) February 15, 2024 08:39
@seakayone seakayone merged commit 52c798d into main Feb 15, 2024
12 of 13 checks passed
@seakayone seakayone deleted the refactor/migrate-more-users-endpoint-to-tapir-2 branch February 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants