New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate user group endpoints to Tapir and remove UserRouteADM #3046
Merged
seakayone
merged 12 commits into
main
from
refactor/migrate-more-users-endpoint-to-tapir-2
Feb 15, 2024
Merged
refactor: Migrate user group endpoints to Tapir and remove UserRouteADM #3046
seakayone
merged 12 commits into
main
from
refactor/migrate-more-users-endpoint-to-tapir-2
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rojectIri>` to Tapir
…<projectIri>` to Tapir
…i>` to Tapir and remove UsersRouteADM.scala
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3046 +/- ##
==========================================
+ Coverage 11.74% 11.99% +0.24%
==========================================
Files 246 262 +16
Lines 22907 22739 -168
==========================================
+ Hits 2690 2727 +37
+ Misses 20217 20012 -205 ☔ View full report in Codecov by Sentry. |
seakayone
requested review from
mpro7,
BalduinLandolt and
siers
and removed request for
mpro7
February 15, 2024 07:51
siers
approved these changes
Feb 15, 2024
seakayone
deleted the
refactor/migrate-more-users-endpoint-to-tapir-2
branch
February 15, 2024 09:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensureSystemAdminOrProjectAdmin(User, ProjectIri)
toAuthorizationRestService
PUT /admin/users/iri/<userIri>/SystemAdmin
to TapirPOST /admin/users/iri/<userIri>/project-memberships/<projectIri>
to TapirDELETE /admin/users/iri/<userIri>/project-memberships/<projectIri>
to TapirPOST /admin/users/iri/<userIri>/project-admin-memberships/<projectIri>
to TapirDELETE /admin/users/iri/<userIri>/project-admin-memberships/<projectIri>
to TapirPOST /admin/users/iri/<userIri>/group-memberships/<groupIri>
to TapirDELETE /admin/users/iri/<userIri>/group-memberships/<groupIri>
to TapirUsersRouteADM
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?