Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use UserService to update a user #3053

Merged
merged 4 commits into from Feb 16, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Feb 16, 2024

Pull Request Checklist

Task Description/Number

  • Remove custom updateUser query and use UserService with UserRepo in order to update a user.
  • Use a single query in UserRepo for save in both update and create cases.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (075833b) 12.01%.
Report is 73 commits behind head on main.

Files Patch % Lines
...knora/webapi/responders/admin/UsersResponder.scala 0.00% 36 Missing ⚠️
...ebapi/slice/admin/domain/service/UserService.scala 0.00% 13 Missing ⚠️
...api/slice/admin/api/service/UsersRestService.scala 0.00% 9 Missing ⚠️
...a/webapi/responders/admin/GroupsResponderADM.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
+ Coverage   11.74%   12.01%   +0.27%     
==========================================
  Files         246      262      +16     
  Lines       22907    22699     -208     
==========================================
+ Hits         2690     2728      +38     
+ Misses      20217    19971     -246     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone force-pushed the refactor/use-Userservice-for-updating-a-User branch from 8fb7e23 to 0841037 Compare February 16, 2024 12:29
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@seakayone seakayone enabled auto-merge (squash) February 16, 2024 12:49
@seakayone seakayone merged commit 25ef280 into main Feb 16, 2024
13 checks passed
@seakayone seakayone deleted the refactor/use-Userservice-for-updating-a-User branch February 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants