Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow hyphens in usernames (DEV-3306) #3055

Merged
merged 1 commit into from Feb 20, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Feb 20, 2024

Pull Request Checklist

Task Description/Number

The user images-reviewer-user is failing Username validation leading to the /admin/users view not being available. There are more users with hyphens on both prods, so they'll now be allowed unless the db is cleaned up at some later point.

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@siers siers self-assigned this Feb 20, 2024
Copy link

linear bot commented Feb 20, 2024

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (6af9366) 88.58%.
Report is 76 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3055       +/-   ##
===========================================
+ Coverage   11.74%   88.58%   +76.83%     
===========================================
  Files         246      263       +17     
  Lines       22907    22659      -248     
===========================================
+ Hits         2690    20072    +17382     
+ Misses      20217     2587    -17630     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siers siers requested review from mpro7, seakayone and BalduinLandolt and removed request for mpro7 February 20, 2024 11:03
@siers siers merged commit 9398d21 into main Feb 20, 2024
13 checks passed
@siers siers deleted the fix/username-hyphens-validation branch February 20, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants