Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Make GET /admin/users faster by caching projects (DEV-3311) #3062

Merged
merged 5 commits into from Feb 27, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Feb 26, 2024

Pull Request Checklist

Task Description/Number

  • Move caching to ProjectADMService
  • Remove configuration allowing to disable caching of ProjectADM

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title fix: Make GET /admin/users faster by caching projects fix: Make GET /admin/users faster by caching projects (DEV-3311) Feb 26, 2024
Copy link

linear bot commented Feb 26, 2024

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (eac5751) to head (99d9466).
Report is 83 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3062       +/-   ##
===========================================
+ Coverage   11.74%   88.54%   +76.80%     
===========================================
  Files         246      262       +16     
  Lines       22907    22620      -287     
===========================================
+ Hits         2690    20029    +17339     
+ Misses      20217     2591    -17626     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone changed the title fix: Make GET /admin/users faster by caching projects (DEV-3311) perf: Make GET /admin/users faster by caching projects (DEV-3311) Feb 26, 2024
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always paranoid when it comes to cache... but looks good, from what I can tell.

@seakayone seakayone merged commit 793f118 into main Feb 27, 2024
16 checks passed
@seakayone seakayone deleted the fix/users-endpoint-slow-add-caching-to-user-service branch February 27, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants