New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Make GET /admin/users faster by caching projects (DEV-3311) #3062
perf: Make GET /admin/users faster by caching projects (DEV-3311) #3062
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3062 +/- ##
===========================================
+ Coverage 11.74% 88.54% +76.80%
===========================================
Files 246 262 +16
Lines 22907 22620 -287
===========================================
+ Hits 2690 20029 +17339
+ Misses 20217 2591 -17626 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always paranoid when it comes to cache... but looks good, from what I can tell.
Pull Request Checklist
Task Description/Number
ProjectADMService
ProjectADM
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?