Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace default watermark for Sipi with new version #3066

Merged
merged 1 commit into from Feb 28, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Feb 28, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (eac5751) to head (6963604).
Report is 86 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3066       +/-   ##
===========================================
+ Coverage   11.74%   88.56%   +76.81%     
===========================================
  Files         246      262       +16     
  Lines       22907    22553      -354     
===========================================
+ Hits         2690    19973    +17283     
+ Misses      20217     2580    -17637     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@danielasubotic danielasubotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seakayone seakayone merged commit 19caebd into main Feb 28, 2024
13 checks passed
@seakayone seakayone deleted the chore/update-sipi-default-watermark branch February 28, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants