Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate PUT /admin/group/<groupIri> to Tapir (DEV-1588) #3071

Merged
merged 9 commits into from Feb 29, 2024

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Feb 28, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1588

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Feb 28, 2024

@mpro7 mpro7 self-assigned this Feb 28, 2024
Copy link

swarmia bot commented Feb 28, 2024

@mpro7 mpro7 changed the title refactor: Migrate PUT /admin/group/ to Tapir refactor: Migrate PUT /admin/group/ to Tapir (DEV-1588) Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.66%. Comparing base (eac5751) to head (a1c9e06).
Report is 92 commits behind head on main.

Files Patch % Lines
...a/webapi/responders/admin/GroupsResponderADM.scala 97.22% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3071       +/-   ##
===========================================
+ Coverage   11.74%   88.66%   +76.91%     
===========================================
  Files         246      262       +16     
  Lines       22907    22457      -450     
===========================================
+ Hits         2690    19911    +17221     
+ Misses      20217     2546    -17671     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 marked this pull request as ready for review February 28, 2024 15:23
@mpro7 mpro7 changed the title refactor: Migrate PUT /admin/group/ to Tapir (DEV-1588) refactor: Migrate PUT /admin/group/<groupIri> to Tapir (DEV-1588) Feb 28, 2024
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpro7 mpro7 merged commit 8df7033 into main Feb 29, 2024
13 checks passed
@mpro7 mpro7 deleted the dev-1588-6 branch February 29, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants