Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The restricted view must be either restricted with a watermark or by a particular size (DEV-3356) #3080

Merged
merged 14 commits into from Mar 4, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Mar 4, 2024

  • Set default value for RestrictedView to !128,128
  • Allow for either having a watermark or a particular size for the RestrictedView in api and service

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 18.00000% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 12.65%. Comparing base (eac5751) to head (238d4ea).
Report is 101 commits behind head on main.

Files Patch % Lines
...lice/admin/repo/service/KnoraProjectRepoLive.scala 0.00% 14 Missing ⚠️
...cala/org/knora/webapi/slice/admin/api/Codecs.scala 0.00% 7 Missing ⚠️
.../model/ProjectsEndpointsRequestsAndResponses.scala 0.00% 5 Missing ⚠️
...ice/admin/api/service/ProjectsADMRestService.scala 0.00% 5 Missing ⚠️
...bapi/slice/admin/domain/model/RestrictedView.scala 63.63% 4 Missing ⚠️
...slice/admin/domain/service/ProjectADMService.scala 0.00% 3 Missing ⚠️
...ora/webapi/slice/admin/api/ProjectsEndpoints.scala 0.00% 2 Missing ⚠️
...webapi/responders/admin/ProjectsResponderADM.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3080      +/-   ##
==========================================
+ Coverage   11.74%   12.65%   +0.91%     
==========================================
  Files         246      261      +15     
  Lines       22907    22363     -544     
==========================================
+ Hits         2690     2831     +141     
+ Misses      20217    19532     -685     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone self-assigned this Mar 4, 2024
@seakayone seakayone changed the title feat: The restricted view must be either restricted with a watermark of by a size (DEV-3356) feat: The restricted view must be either restricted with a watermark or by a particular size (DEV-3356) Mar 4, 2024
@seakayone seakayone force-pushed the feat/either-restricted-view-or-watermark branch from fe0fcba to 8c48d46 Compare March 4, 2024 09:39
@seakayone seakayone requested review from BalduinLandolt, mpro7 and siers and removed request for BalduinLandolt March 4, 2024 09:41
@seakayone seakayone marked this pull request as ready for review March 4, 2024 09:47
@seakayone seakayone enabled auto-merge (squash) March 4, 2024 15:50
@seakayone seakayone merged commit 75f5363 into main Mar 4, 2024
13 checks passed
@seakayone seakayone deleted the feat/either-restricted-view-or-watermark branch March 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants